-
Notifications
You must be signed in to change notification settings - Fork 171
add ohm & sohm icons #1454
base: master
Are you sure you want to change the base?
add ohm & sohm icons #1454
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/ledgerhq/ledger-live-common/9KjPohMrN6UQ4jB6Tvmi2xYjYpK1 |
src/data/icons/svg/SOHM.svg
Outdated
<!-- Generator: Adobe Illustrator 25.4.1, SVG Export Plug-In . SVG Version: 6.00 Build 0) --> | ||
<svg version="1.1" id="Layer_1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" x="0px" y="0px" | ||
viewBox="0 0 1000 1000" style="enable-background:new 0 0 1000 1000;" xml:space="preserve"> | ||
<style type="text/css"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hello thanks for the contribution.
We don't accepts any <style> tag or style attribute within a svg icons.
These svg files are parsed in order for them to be consumed by our live app on both mobile and desktop and have to follow a strict format to do so.
try limiting the icon to a single path and a single color aswell to make it flat. 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, we are working on updating our icon per your specs ^^^
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LFBarreto we've updated the tokens & added a new token, WSOHM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also added WSOHM token address via the form here: https://developers.ledger.com/docs/token/erc20-bep20/#2-how-to-get-my-token-listed
@@ -0,0 +1,8 @@ | |||
<svg version="1.1" id="Layer_1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" x="0px" y="0px" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution. could you merge master in? we have extra test that do some checks to ensure icons are fine. Thanks
Unfortunately, we can't afford to have id=
, class=
or <style>
in these SVG because we will convert them back into react class.
I still see some style and ids in the SOHM and WSOHM files.
Context (issues, jira)
NA.
OHM Token already exists here: https://github.com/LedgerHQ/ledgerjs/blob/48577c43ce81e87d09203dc240c608393a48da33/packages/cryptoassets/data/erc20.js#L1730
SOHM Token was added via this form this past week: https://developers.ledger.com/docs/token/erc20-bep20/#2-how-to-get-my-token-listed
Description / Usage
Add Logos for OHM & SOHM tokens.
Expectations