This repository has been archived by the owner on Jun 16, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 299
[LIVE-1036] - Feature: Add NFT counter value #4886
Open
lambertkevin
wants to merge
12
commits into
develop
Choose a base branch
from
feat/add-nft-counter-value
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lambertkevin
changed the base branch from
develop
to
feat/upgrade-nft-architecture
April 1, 2022 17:54
Thanks for your contribution.
Why /generate-screenshots ?If your PR contains UI related changes, |
Coverage report
Test suite run failedFailed tests: 1/6. Failed suites: 1/2.
Report generated by 🧪jest coverage report action from 9eddb9c |
lambertkevin
force-pushed
the
feat/upgrade-nft-architecture
branch
2 times, most recently
from
April 5, 2022 21:14
c4db70f
to
6b7c853
Compare
lambertkevin
force-pushed
the
release/2.41.x
branch
8 times, most recently
from
April 12, 2022 17:43
7d3220e
to
6d5bae6
Compare
lambertkevin
force-pushed
the
release/2.41.x
branch
3 times, most recently
from
April 20, 2022 09:19
5931df6
to
bca04fc
Compare
lambertkevin
force-pushed
the
release/2.41.x
branch
from
April 28, 2022 15:18
e832255
to
81782e4
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependencies
#4870
LedgerHQ/ledger-live-common#1805
🦒 Context (issues, jira)
https://ledgerhq.atlassian.net/browse/LIVE-1036
💻 Description / Demo (image or video)
Screen.Recording.2022-04-01.at.19.53.13.mov
🖤 Expectations to reach
PR must pass CI, rebase develop if conflicts. Thanks!