This repository has been archived by the owner on Jun 16, 2022. It is now read-only.
fix/market details screen nav #4945
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
Test suite run success2 tests passing in 2 suites.Report generated by 🧪jest coverage report action from 3116662 |
|
/generate-screenshots |
|
CI is not running, does this have a linked Jira task? |
|
the branch name should be |
LFBarreto
force-pushed
the
fix/market-details-screen-nav
branch
from
25768f2 to
3116662
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦒 Context (issues, jira)
💻 Description / Demo (image or video)
Fixes issue on navigation on market details page.
Now data shows up instantly + double breadcrumb fix + removal of forced refresh when coming back to main list page.
fix-market-2022-04-26_08.45.56.mp4
🖤 Expectations to reach
PR must pass CI, rebase develop if conflicts. Thanks!