Skip to content
This repository has been archived by the owner on Jun 16, 2022. It is now read-only.

[FEATURE] Add FTX to live swap #4959

Open
wants to merge 75 commits into
base: develop
Choose a base branch
from
Open

[FEATURE] Add FTX to live swap #4959

wants to merge 75 commits into from

Conversation

chabroA
Copy link
Contributor

@chabroA chabroA commented May 2, 2022

🦒 Context (issues, jira)

💻 Description / Demo (image or video)

🔗 LedgerHQ/ledger-live-common#1927

  • Add FTX as swap provider
  • Add Login, KYC and MFA widgets to swap flow
  • Add change provider option to change rate / provider
  • Update settings to allow reset third party data (and thus clean partner login / KYC data stored locally)

📸 Screenshot of updated parts bellow 👇

Settings page

3

3

3 1

3 1

Swap page

Before:

1

2

After:

1 2
New widgets

Screenshot 2022-03-04 at 17 15 15
Screenshot 2022-03-04 at 17 15 47

🧪 QA steps:

To put it shortly, test the different login / KYC flows for swap with FTX and FTX US.
FTX should always be first provider available.

You can use these test credentials in order to test each flow. Follow the instruction on the page to use a test account.
⚠️ Do not try to update KYC (i.e: submit the form) or enable MFA on any of these test accounts ⚠️

Use provider 7 to get the compatible nano apps

🖤 Expectations to reach

PR must pass CI, rebase develop if conflicts. Thanks!

  • on QA: at least one of these two checkboxes must be checked:
    • a specific test planned is defined on Jira
    • this PR is covered by automatic UI test
  • on delivery: at least one of these two checkboxes must be checked:
    • Option 1: no impact: The changes of this PR have ZERO impact on the userland (invisible for users)
    • Option 2: atomic delivery: the changes is atomic and complete (no partial delivery)

☑️ TODO before merge / release

  • update LLC dep
  • remove SWAP_API_BASE env override (once swap api is in prod)
  • deploy nano apps from provider 7 to prod

@github-actions
Copy link

github-actions bot commented May 2, 2022

Thanks for your contribution.
To be groomed for next release, you need to:

  • pass the CI
  • if needed, run /generate-screenshots
  • have a dev review
  • have a QA review

Why /generate-screenshots ?

If your PR contains UI related changes,
it might be necessary to regenerate screenshots.

@github-actions
Copy link

github-actions bot commented May 2, 2022

Coverage report

St.
Category Percentage Covered / Total
🔴 Statements 23.46% 38/162
🔴 Branches 20.51% 8/39
🔴 Functions 3.64% 2/55
🔴 Lines 24.16% 36/149

Test suite run success

2 tests passing in 2 suites.

Report generated by 🧪jest coverage report action from 4f19bb2

@chabroA chabroA force-pushed the feat/add-ftx-to-swap branch from de49d13 to 89cbc0e Compare May 3, 2022 09:58
@chabroA chabroA force-pushed the feat/add-ftx-to-swap branch from 89cbc0e to d5dfebe Compare May 3, 2022 12:37
@chabroA chabroA added the HODL for PRs: this is blocked, we can't merge yet label May 4, 2022
@chabroA chabroA marked this pull request as ready for review May 4, 2022 14:14
@chabroA chabroA requested a review from a team as a code owner May 4, 2022 14:14
@chabroA chabroA requested a review from a team May 4, 2022 14:14
@chabroA chabroA requested a review from a team as a code owner May 4, 2022 14:14
@chabroA chabroA requested a review from a team May 4, 2022 14:14
@chabroA chabroA requested review from a team as code owners May 4, 2022 14:14
@chabroA chabroA mentioned this pull request May 16, 2022
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
HODL for PRs: this is blocked, we can't merge yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants