This repository has been archived by the owner on Jun 16, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 299
[FEATURE] Add FTX to live swap #4959
Open
chabroA
wants to merge
75
commits into
develop
Choose a base branch
from
feat/add-ftx-to-swap
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for your contribution.
Why /generate-screenshots ?If your PR contains UI related changes, |
Coverage report
Test suite run success2 tests passing in 2 suites.Report generated by 🧪jest coverage report action from 4f19bb2 |
chabroA
force-pushed
the
feat/add-ftx-to-swap
branch
from
May 3, 2022 09:58
de49d13
to
89cbc0e
Compare
To clear the session’s HTTP cache Used to remove third party cached auth tokens, among other things
We don't reset only the KYC but all third party related data stored locally
chabroA
force-pushed
the
feat/add-ftx-to-swap
branch
from
May 3, 2022 12:37
89cbc0e
to
d5dfebe
Compare
2 tasks
Instead of raw provider value to display proper provider name and not its id
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦒 Context (issues, jira)
💻 Description / Demo (image or video)
🔗 LedgerHQ/ledger-live-common#1927
📸 Screenshot of updated parts bellow 👇
Settings page
Swap page
Before:
After:
New widgets
🧪 QA steps:
To put it shortly, test the different login / KYC flows for swap with FTX and FTX US.
FTX should always be first provider available.
You can use these test credentials in order to test each flow. Follow the instruction on the page to use a test account.
⚠️ Do not try to update KYC (i.e: submit the form) or enable MFA on any of these test accounts ⚠️
Use provider
7
to get the compatible nano apps🖤 Expectations to reach
PR must pass CI, rebase develop if conflicts. Thanks!
☑️ TODO before merge / release
SWAP_API_BASE
env override (once swap api is in prod)7
to prod