💄(lld): update sync flow and copy for LS (#7851)

LedgerHQ · Sep 19, 2024 · 5e4272d · 5e4272d
1 parent 75e8548
commit 5e4272d
Show file tree

Hide file tree

Showing 5 changed files with 22 additions and 13 deletions.
diff --git a/.changeset/smart-mails-refuse.md b/.changeset/smart-mails-refuse.md
@@ -0,0 +1,5 @@
+---
+"ledger-live-desktop": patch
+---
+
+Update sync flow for LS when active on instance and copy
diff --git a/apps/ledger-live-desktop/src/newArch/features/WalletSync/__tests__/synchronize.test.tsx b/apps/ledger-live-desktop/src/newArch/features/WalletSync/__tests__/synchronize.test.tsx
@@ -51,11 +51,6 @@ describe("Synchronize flow", () => {
 
  await user.click(row);
 
- // Select Sync with QRCode
- await waitFor(() => expect(screen.getByTestId("walletSync-synchronize-scan")).toBeDefined());
- const qrCodeCard = screen.getByTestId("walletSync-synchronize-scan");
- await user.click(qrCodeCard);
-
  // QRCode Page
  await waitFor(() =>
  expect(

diff --git a/apps/ledger-live-desktop/src/newArch/features/WalletSync/screens/Manage/index.tsx b/apps/ledger-live-desktop/src/newArch/features/WalletSync/screens/Manage/index.tsx
@@ -34,7 +34,7 @@ const WalletSyncManage = () => {
  const { onClickTrack } = useLedgerSyncAnalytics();
 
  const goToSync = () => {
- dispatch(setFlow({ flow: Flow.Synchronize, step: Step.SynchronizeMode }));
+ dispatch(setFlow({ flow: Flow.Synchronize, step: Step.SynchronizeWithQRCode }));
 
  onClickTrack({ button: "Synchronize", page: AnalyticsPage.LedgerSyncSettings });
  };

diff --git a/apps/ledger-live-desktop/src/newArch/features/WalletSync/screens/Synchronize/index.tsx b/apps/ledger-live-desktop/src/newArch/features/WalletSync/screens/Synchronize/index.tsx
@@ -27,11 +27,20 @@ const SynchronizeWallet = forwardRef<BackRef, BackProps>((_props, ref) => {
  goBack,
  }));
 
- const { currentStep, goToNextScene, goToPreviousScene, goToWelcomeScreenWalletSync } = useFlows();
+ const {
+ currentStep,
+ goToNextScene,
+ goToPreviousScene,
+ goToWelcomeScreenWalletSync,
+ currentFlow,
+ } = useFlows();
  const { onClickTrack } = useLedgerSyncAnalytics();
 
  const goBack = () => {
- if (currentStep === FlowOptions[Flow.Synchronize].steps[1]) {
+ if (
+ currentStep === FlowOptions[Flow.Synchronize].steps[1] ||
+ (currentFlow === Flow.Synchronize && currentStep === Step.SynchronizeWithQRCode)
+ ) {
  goToWelcomeScreenWalletSync();
  } else {
  goToPreviousScene();

diff --git a/apps/ledger-live-desktop/static/i18n/en/app.json b/apps/ledger-live-desktop/static/i18n/en/app.json
@@ -6457,8 +6457,8 @@
  "manage": {
  "cta": "Manage",
  "synchronize": {
- "label": "Synchronize",
- "description": "Synchronize your accounts with another Ledger Live app for a seamless experience."
+ "label": "Sync with another Ledger Live app",
+ "description": "Sync your Ledger Live crypto accounts across different phones and computers."
  },
  "backup": {
  "label": "Delete sync",
@@ -6547,10 +6547,10 @@
  }
  },
  "qrCode": {
- "title": "Synchronize Instances",
+ "title": "Sync your Ledger Live apps",
  "options": {
- "mobile": "Mobile",
- "desktop": "Desktop"
+ "mobile": "Sync with phone",
+ "desktop": "Sync with computer"
  },
  "mobile": {
  "description": "Scan and synchronize your accounts with another Ledger Live app",