Merge pull request #7872 from LedgerHQ/bugfix/wallet-api-llm-open-any…

…-deeplink fix(wallet-api): open any deep-link from the webview on LLM
LedgerHQ · Sep 26, 2024 · ecb8f3f · ecb8f3f
2 parents bb822fa + 7eb4f48
commit ecb8f3f
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 14 deletions.
diff --git a/.changeset/tough-terms-film.md b/.changeset/tough-terms-film.md
@@ -0,0 +1,7 @@
+---
+"live-mobile": patch
+---
+
+fix(wallet-api): open any deep-link from the webview on LLM
+
+Needed for wallet-connect-live-app deep-link back to mobile dApps
diff --git a/apps/ledger-live-mobile/src/components/Web3AppWebview/PlatformAPIWebview.tsx b/apps/ledger-live-mobile/src/components/Web3AppWebview/PlatformAPIWebview.tsx
@@ -507,13 +507,9 @@ export const PlatformAPIWebview = forwardRef<WebviewAPI, WebviewProps>(
 
  const onOpenWindow = useCallback((event: WebViewOpenWindowEvent) => {
  const { targetUrl } = event.nativeEvent;
- Linking.canOpenURL(targetUrl).then(supported => {
- if (supported) {
- Linking.openURL(targetUrl);
- } else {
- console.error(`Don't know how to open URI: ${targetUrl}`);
- }
- });
+ // Don't use canOpenURL as we cannot check unknown apps on the phone
+ // Without listing everything in plist and android manifest
+ Linking.openURL(targetUrl);
  }, []);
 
  useEffect(() => {

diff --git a/apps/ledger-live-mobile/src/components/Web3AppWebview/helpers.ts b/apps/ledger-live-mobile/src/components/Web3AppWebview/helpers.ts
@@ -163,13 +163,9 @@ export function useWebView(
 
  const onOpenWindow = useCallback((event: WebViewOpenWindowEvent) => {
  const { targetUrl } = event.nativeEvent;
- Linking.canOpenURL(targetUrl).then(supported => {
- if (supported) {
- Linking.openURL(targetUrl);
- } else {
- console.error(`Don't know how to open URI: ${targetUrl}`);
- }
- });
+ // Don't use canOpenURL as we cannot check unknown apps on the phone
+ // Without listing everything in plist and android manifest
+ Linking.openURL(targetUrl);
  }, []);
 
  return {