LIVE-14383 working display of team link #8028
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 5 Skipped Deployments
|
live-github-bot
bot
added
desktop
Wozacosta
changed the title
Wozacosta
force-pushed
the
chore/link-zondax-website
branch
from
f222370
to
0093e6b
Compare
hedi-edelbloute
previously approved these changes
Oct 8, 2024
Wozacosta
force-pushed
the
chore/link-zondax-website
branch
from
0093e6b
to
590f770
Compare
LucasWerey
previously approved these changes
Oct 9, 2024
themooneer
reviewed
Oct 9, 2024
| <ExternalLinkIconContainer> | ||
| <IconExternalLink size={12} /> | ||
| </ExternalLinkIconContainer> | ||
| </Link>{" "} |
There was a problem hiding this comment.
It's actually required to not have the link stuck to the surrounding works, not using padding/margin allows the renderer to break the line where needed.
There was a problem hiding this comment.
you can use a none braking space , its more native than this.
themooneer
reviewed
Oct 9, 2024
apps/ledger-live-desktop/src/renderer/components/AccountSubHeader/AccountSubHeaderDrawer.tsx
Outdated
Show resolved
Hide resolved
themooneer
reviewed
Oct 9, 2024
apps/ledger-live-desktop/src/renderer/components/AccountSubHeader/AccountSubHeaderDrawer.tsx
Outdated
Show resolved
Hide resolved
Wozacosta
dismissed stale reviews from LucasWerey and hedi-edelbloute
via
b804236
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
Third party integration teams, assuming they provided a link, now get's their team names clickable in the "integrated by" drawer
Before LLM:
After LLM:
LLD
❓ Context
🧐 Checklist for the PR Reviewers