Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COIN-FMK] Remove transport dependencies #8030

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

sprohaszka-ledger
Copy link
Contributor

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Remove Transport dependency from CoinFmk (undesired dependency).
Move SpeculosButton definition to the more appropriate type.ts file.

❓ Context

  • JIRA or GitHub link: N/A

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Signed-off-by: Stéphane Prohaszka <stephane.prohaszka@ledger.fr>
Copy link

vercel bot commented Oct 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Oct 7, 2024 2:18pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Oct 7, 2024 2:18pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 7, 2024 2:18pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 7, 2024 2:18pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Oct 7, 2024 2:18pm

@live-github-bot live-github-bot bot added the common Has changes in live-common label Oct 7, 2024
Signed-off-by: Stéphane Prohaszka <stephane.prohaszka@ledger.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant