feat(web3Hub): add recently used #8050
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 5 Skipped Deployments
|
| }; | ||
| export type RecentlyUsed = AppManifest; | ||
|
|
||
| // export type RecentlyUsed = { |
There was a problem hiding this comment.
Do we want to keep this comment?
There was a problem hiding this comment.
You want to revert this change, the simplest way is usually to do a git checkout develop apps/ledger-live-mobile/ios/ledgerlivemobile.xcodeproj/project.pbxproj
There was a problem hiding this comment.
Also it happens if we have xcode 16 installed I think and you can use https://github.com/XcodesOrg/xcodes to download any version like the 15.4 we currently use for develop and on CI (actually it's 15.3 I think)
| useEffect(() => { | ||
| setWeb3HubDB(INITIAL_WEB3HUB_STATE); | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps | ||
| }, []); | ||
|
|
There was a problem hiding this comment.
I think that I was using this to avoid having the input selected if I close and open the disclaimer again, but we clearly don't want to reset the states when using the hook
| expect(screen.getByRole("searchbox")).toBeEnabled(); | ||
|
|
||
| expect(await screen.findByText("Recently used")).toBeOnTheScreen(); | ||
| expect(await screen.findByTestId("recently-used-dummy-0")).toBeOnTheScreen(); |
There was a problem hiding this comment.
We also want to limit the usage of testIds to the bare minimum and try to use other user friendly way to find elements
https://testing-library.com/docs/queries/about#priority
✅ Checklist
npx changesetwas attached.📝 Description
demo-recently-used.mp4
❓ Context
🧐 Checklist for the PR Reviewers