Fix bug where flag stakePrograms was not checked into account screen,… #8059
+38
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… add check on flag into bitcoin header actions
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 5 Skipped Deployments
|
beths-ledger
previously approved these changes
Oct 9, 2024
apps/ledger-live-desktop/src/renderer/families/bitcoin/AccountHeaderManageActions.ts
Show resolved
Hide resolved
themooneer
reviewed
Oct 9, 2024
apps/ledger-live-desktop/src/renderer/families/bitcoin/AccountHeaderManageActions.ts
Show resolved
Hide resolved
LucasWerey
reviewed
Oct 9, 2024
apps/ledger-live-desktop/src/renderer/families/bitcoin/AccountHeaderManageActions.ts
Show resolved
Hide resolved
apps/ledger-live-desktop/src/renderer/families/bitcoin/AccountHeaderManageActions.ts
Show resolved
Hide resolved
themooneer
previously approved these changes
Oct 9, 2024
hedi-edelbloute
previously approved these changes
Oct 10, 2024
adammino-ledger
dismissed stale reviews from hedi-edelbloute, themooneer, and beths-ledger
via
88cdfb0
ypolishchuk-ledger
previously approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR fixes a bug where the
stakeProgramsflag was not checked into the Account tab screen therefore even if a currency was disabled on it, it would show thestakeentrypoint.There is also an additional check for bitcoin action on the stakePrograms to be sure it's not displayed anywhere if disabled.
🧐 Checklist for the PR Reviewers