Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ (lld x Speculos): Using cli to build app.json #8065

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

✨ (lld x Speculos): Using cli to build app.json #8065

wants to merge 1 commit into from
+32 −2

Conversation

VicAlbr
Copy link
Contributor

@VicAlbr VicAlbr commented Oct 10, 2024 •
edited
Loading

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Use the cli to craft the app.json used in the speculos e2e test

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@vercel Vercel
Copy link

vercel bot commented Oct 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Oct 10, 2024 2:28pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Oct 10, 2024 2:28pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 10, 2024 2:28pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 10, 2024 2:28pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Oct 10, 2024 2:28pm

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Oct 10, 2024
@VicAlbr VicAlbr marked this pull request as ready for review October 10, 2024 14:27
@VicAlbr VicAlbr requested review from a team as code owners October 10, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abdurrahman-ledger abdurrahman-ledger abdurrahman-ledger approved these changes

Assignees

@VicAlbr VicAlbr

Labels
desktop Has changes in LLD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VicAlbr @abdurrahman-ledger