feat(web3Hub): fix state management with jotai #8069
+44
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 5 Skipped Deployments
|
Canestin
commented
Oct 10, 2024
Comment on lines
+9
to
+22
| export const storage = createJSONStorage<Web3HubDB>(() => AsyncStorage); | ||
|
|
||
| export const web3hubAtom = atomWithStorage<Web3HubDB>( | ||
| WEB3HUB_STORE_KEY, | ||
| INITIAL_WEB3HUB_STATE, | ||
| storage, | ||
| ); | ||
|
|
||
| type NewState = Web3HubDB | ((s: Web3HubDB) => Web3HubDB); | ||
|
|
||
| export function useWeb3HubDB<Selected>( | ||
| selector: (state: Web3HubDB) => Selected, | ||
| ): [Selected, (v: NewState) => void] { | ||
| const [state, setState] = useAtom(web3hubAtom); |
There was a problem hiding this comment.
Ideally I would like to use this logic in live-common (by generalizing) and replace the one in useDB.
Justkant
reviewed
Oct 11, 2024
| @@ -154,6 +154,7 @@ | |||
| "hoist-non-react-statics": "3.3.2", | |||
| "i18next": "20.6.1", | |||
| "invariant": "2.2.4", | |||
| "jotai": "^2.7.0", | |||
There was a problem hiding this comment.
Small detail but we could update jotai to the latest version, it includes some fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
Problem
Currently, the way we update the app storage causes issues because the data state isn't shared between instances.
Specifically, when we modify a variable with instance X, the state of instance Y isn't updated (as the state isn't shared). As a result, if two different instances update the app storage at the same time, only the last modification is applied, leading to potential data loss.
Solution
Ensure that the database state is shared across all instances. This way, a modification in instance Z will automatically reflect in instance Y, by using
Jotainpm lib, a lightweight library that simplifies state management across an application.demo.mp4
🧐 Checklist for the PR Reviewers