Merge pull request #766 from LedgerHQ/kme_pending_review_refacto

Kme Add flag pending review refacto.

Makefile.standard_app

@@ -198,8 +198,15 @@ ifeq ($(HAVE_APPLICATION_FLAG_LIBRARY), 1)
 # APPLICATION_FLAG_LIBRARY 0x800
 STANDARD_APP_FLAGS := $(shell echo $$(($(STANDARD_APP_FLAGS) + 0x800)))
 endif
+ifeq ($(HAVE_APPLICATION_FLAG_NOT_REVIEWED), 1)
+# APPLICATION_FLAG_LIBRARY 0x2000
+STANDARD_APP_FLAGS := $(shell echo $$(($(STANDARD_APP_FLAGS) + 0x20000)))
+endif
+
 
+# deprecated
 # Pending review flag
+# use HAVE_APPLICATION_FLAG_NOT_REVIEWED flag instead
 ifeq ($(ENABLE_PENDING_REVIEW_SCREEN), 1)
  TLVRAW_APP_LOAD_PARAMS += 9F:01
  DEFINES += HAVE_PENDING_REVIEW_SCREEN

include/appflags.h

@@ -80,6 +80,11 @@
  */
 #define APPLICATION_FLAG_BACKGROUND_IMG 0x10000
 
+/**
+ * Application was not yet audited by ledger
+ */
+#define APPLICATION_FLAG_NOT_REVIEWED 0x20000
+
 /**
  * Custom AEM flag to test AEM capabilities without standard UX permissions
  */
@@ -89,15 +94,9 @@
 #define APPLICATION_FLAG_AEM_PIN APPLICATION_FLAG_BOLOS_UX
 #endif // BOLOS_DEBUG_UX_PERMISSION_FLAG
 
-#ifdef HAVE_BACKGROUND_IMG
 #define APPLICATION_FLAGS_MASK (0x00000000FFFFFFFFULL)
 #define APPLICATION_FLAG_NEG_MASK (0xFFFFFFFF00000000ULL)
 #define APPLICATION_FLAGS_SHIFT (32)
-#else
-#define APPLICATION_FLAGS_MASK (0x0000FFFF)
-#define APPLICATION_FLAG_NEG_MASK (0xFFFF0000)
-#define APPLICATION_FLAGS_SHIFT (16)
-#endif // HAVE_BACKGROUND_IMG
 
 #define GET_COMPLEMENTED_APPLICATION_FLAGS(flags) \
  (((~((flags) &APPLICATION_FLAGS_MASK) << APPLICATION_FLAGS_SHIFT)) \

include/os_app.h

@@ -38,13 +38,8 @@ typedef struct application_s {
  // into Thumb code
  appmain_t main;
 
-#ifdef HAVE_BACKGROUND_IMG
  // special flags for this application
  uint64_t flags;
-#else
- // special flags for this application
- uint32_t flags;
-#endif
 
  // Memory organization: [ code (RX) |alignpage| data (RW) |alignpage| install params (R) ]