Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B2CA-969: Activate pinpad and fix CCID SC_Secure #499

Merged
merged 3 commits into from
Jan 18, 2024

Conversation

cedelavergne-ledger
Copy link
Contributor

Description

This PR

  • Adds a pinpad activation, allowing to set the password (usefull for Apps like OpenPGP).
  • Fixes the SC_Secure function because the data parsing was not aligned with CCID spec, and the returned payload caused the app crashing
  • In addition, few fix for compilation warnings about code formatting.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)

@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (87f3e3e) 60.18% compared to head (00a5310) 60.18%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #499   +/-   ##
=======================================
  Coverage   60.18%   60.18%           
=======================================
  Files          12       12           
  Lines        1660     1660           
=======================================
  Hits          999      999           
  Misses        661      661           
Flag Coverage Δ
unittests 60.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cedelavergne-ledger cedelavergne-ledger merged commit 3957522 into master Jan 18, 2024
161 checks passed
@cedelavergne-ledger cedelavergne-ledger deleted the cev/B2CA-969_ccid-pinpad branch January 18, 2024 14:34
This was referenced Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants