Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt NBGL to europa design rules #519

Merged
merged 4 commits into from
Feb 3, 2024

Conversation

nroggeman-ledger
Copy link
Contributor

Description

Following Europa UX definition, new design rules have been defined and need to be implemented in NBGL.
Especially regarding:

  • Margins (external and internal)
  • Buttons size
  • Suggestion buttons

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • [*] New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (europa_target@aeee4d9). Click here to learn what that means.

Additional details and impacted files
@@               Coverage Diff                @@
##             europa_target     #519   +/-   ##
================================================
  Coverage                 ?   60.21%           
================================================
  Files                    ?       12           
  Lines                    ?     1664           
  Branches                 ?        0           
================================================
  Hits                     ?     1002           
  Misses                   ?      662           
  Partials                 ?        0           
Flag Coverage Δ
unittests 60.21% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nroggeman-ledger nroggeman-ledger force-pushed the adapt-nbgl-to-europa-design-rules branch 5 times, most recently from 72964fa to 59a7619 Compare January 31, 2024 15:14
@nroggeman-ledger nroggeman-ledger merged commit 5d975b8 into europa_target Feb 3, 2024
159 checks passed
@nroggeman-ledger nroggeman-ledger deleted the adapt-nbgl-to-europa-design-rules branch February 3, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants