Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve some widgets to add icon #530

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

cedelavergne-ledger
Copy link
Contributor

@cedelavergne-ledger cedelavergne-ledger commented Feb 9, 2024

Description

Possibility to add icons on some widgets:

  • Add BARS_LIST_ICONS to have a left icon
  • Add nbgl_layoutAddChoiceButtonsIcon allowing an icon on the top button
  • Add nbgl_pageDrawInfoIcon, calling nbgl_layoutAddChoiceButtonsIcon
  • Add nbgl_useCaseHomeExtIcon to have an icon on the actionButton

Changes include

  • New feature (non-breaking change that adds functionality)

@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.42%. Comparing base (876b8a5) to head (540dbf8).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #530   +/-   ##
=======================================
  Coverage   60.42%   60.42%           
=======================================
  Files          12       12           
  Lines        1660     1660           
=======================================
  Hits         1003     1003           
  Misses        657      657           
Flag Coverage Δ
unittests 60.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cedelavergne-ledger cedelavergne-ledger force-pushed the cev/contol_with_icons branch 3 times, most recently from 631efa6 to a140bce Compare February 16, 2024 13:56
@cedelavergne-ledger cedelavergne-ledger force-pushed the cev/contol_with_icons branch 3 times, most recently from 610acb1 to edb8c7a Compare February 22, 2024 17:43
- Allow text1 and text2, instead of text1 or text2
- Add icon between the QR Code and the text lines
- Increase max layout children up tp 4
- Force QR Code V10 (smaller than V4) if icon and text1 and text2 are provided
@cedelavergne-ledger cedelavergne-ledger force-pushed the cev/contol_with_icons branch 2 times, most recently from e848486 to 540dbf8 Compare February 27, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants