Cherry pick for API_LEVEL_15 #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 5d6dc63)
We might consider that it's the callback responsability to init it, but as it's not what is done in displayReviewPage() and it is safer for a small cost, let's do it! (cherry picked from commit 2acfea8)
(cherry picked from commit 9407ddd)
(cherry picked from commit 5567b62)
This allow to force displaying a tag/value pair in a new page, hence allowing to display pairs in group when relevant. (cherry picked from commit 9c844af)
(cherry picked from commit 8770776)
(cherry picked from commit 0016a0b)
(cherry picked from commit 2b4d131)
(cherry picked from commit a456658)
(cherry picked from commit b106c7b)
(cherry picked from commit aaded6e)
…flag (cherry picked from commit e255f0f)
(cherry picked from commit b9233e6)
(cherry picked from commit d79c1d9)
(cherry picked from commit c7d1a21)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## API_LEVEL_15 #538 +/- ##
===============================================
Coverage ? 60.42%
===============================================
Files ? 12
Lines ? 1660
Branches ? 0
===============================================
Hits ? 1003
Misses ? 657
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cedelavergne-ledger
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Includes all commits from
master(as of 2024-02-20) up to the merge commit of #535 (876b8a5)Basically it contains:
Changes include