Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FWEO-1192 - New UI for Stax #696

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Conversation

nroggeman-ledger
Copy link
Contributor

@nroggeman-ledger nroggeman-ledger commented Jun 13, 2024

Description

The goal of this PR is to adapt NBGL to new Stax design, aligned on Flex one. According to https://ledgerhq.atlassian.net/browse/FWEO-1192

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • [*] New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

@nroggeman-ledger nroggeman-ledger force-pushed the fweo-1192-new-ui-for-stax branch 2 times, most recently from c302120 to 7bc4441 Compare June 13, 2024 09:34
@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 60.19%. Comparing base (8cfa715) to head (45f60a4).

Files Patch % Lines
lib_nbgl/src/nbgl_obj.c 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #696      +/-   ##
==========================================
- Coverage   60.54%   60.19%   -0.35%     
==========================================
  Files          12       12              
  Lines        1726     1726              
==========================================
- Hits         1045     1039       -6     
- Misses        681      687       +6     
Flag Coverage Δ
unittests 60.19% <0.00%> (-0.35%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nroggeman-ledger nroggeman-ledger force-pushed the fweo-1192-new-ui-for-stax branch 2 times, most recently from 59528ea to c62b03d Compare June 13, 2024 11:35
@nroggeman-ledger nroggeman-ledger merged commit 7583aee into master Jun 14, 2024
191 of 192 checks passed
@nroggeman-ledger nroggeman-ledger deleted the fweo-1192-new-ui-for-stax branch June 14, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants