Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong bpp value when drawing radio buttons #725

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

nroggeman-ledger
Copy link
Contributor

Description

The goal of this PR is to fix wrong bpp value set when drawing radio buttons. It was forced to 1BPP but radio buttons can be 1, 2 or 4 BPP

Changes include

  • [*] Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 60.20%. Comparing base (44b02b4) to head (9d30e84).

Files Patch % Lines
lib_nbgl/src/nbgl_obj.c 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #725      +/-   ##
==========================================
+ Coverage   60.19%   60.20%   +0.01%     
==========================================
  Files          12       12              
  Lines        1726     1729       +3     
==========================================
+ Hits         1039     1041       +2     
- Misses        687      688       +1     
Flag Coverage Δ
unittests 60.20% <71.42%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nroggeman-ledger nroggeman-ledger merged commit bf24ae5 into master Jul 12, 2024
193 of 194 checks passed
@nroggeman-ledger nroggeman-ledger deleted the fix-wrong-bpp-in-radio-buttons branch July 12, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants