Add up footer layout object and tip-box object #727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #727 +/- ##
=======================================
Coverage 60.20% 60.20%
=======================================
Files 12 12
Lines 1729 1729
=======================================
Hits 1041 1041
Misses 688 688
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
nroggeman-ledger
force-pushed
the
add-up-footer-layout-object
branch
from
f1493cd
to
abe6d1d
Compare
nroggeman-ledger
force-pushed
the
add-up-footer-layout-object
branch
from
abe6d1d
to
fa3dac6
Compare
cedelavergne-ledger
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The original goal of this PR is to support Tip-Box, as on the attached picture (from https://www.figma.com/design/k9Q6hP0XWAw00AiT6GDb0O/02.-App-SDK?node-id=94-69834&t=ZUjo31oi2l0Y5sc1-4)
To do so, it's necessary to add a up-footer object (and container) in layout layer. This addition enable to regroup other "similar" objects in this up-footer object, like long-press button, horizontal buttons and simple button (in case of button in bottom)
Moreover, to link the content of the tip-box to the centered info), an extended centered info has to be created.
Finally, an nbgl_useCaseAdvancedReview() API is created to be able to use this tip-box in the case illustrated by the attached picture
Changes include