Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fido: Remove old usb hack #728

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Fido: Remove old usb hack #728

merged 1 commit into from
Jul 17, 2024

Conversation

yrichard-ledger
Copy link
Contributor

@yrichard-ledger yrichard-ledger commented Jul 16, 2024

Don't re-configure u2f endpoints every time the host sends a GetDescriptor

Description

FIDO over USB crashes on android because Android makes GetDescriptor requests between authenticator operations.
This PR fixes that issue by removing the old hacky code that was present in the GetReportDescriptor_impl function.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

Don't re-configure u2f endpoints every time the host sends a GetDescriptor
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.20%. Comparing base (bf24ae5) to head (c49427f).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #728   +/-   ##
=======================================
  Coverage   60.20%   60.20%           
=======================================
  Files          12       12           
  Lines        1729     1729           
=======================================
  Hits         1041     1041           
  Misses        688      688           
Flag Coverage Δ
unittests 60.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@lpascal-ledger lpascal-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't say if this is technically correct, but it seems to correctly fix the faulty behavior.

@yrichard-ledger yrichard-ledger merged commit 1c29cb4 into master Jul 17, 2024
193 of 194 checks passed
@yrichard-ledger yrichard-ledger deleted the fido-usb-fixup branch July 17, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants