Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove language dependency from NBGL #750

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

nroggeman-ledger
Copy link
Contributor

Description

The goal of this PR is to remove the dependency existing between NBGL and languages:

  • ids used to identify localized strings
  • Global language_pack variable used in Fonts management library

This is a first necessary step to use NBGL as a common library for OS and Apps.

It only breaks compatibility with the OS (removed field in some objects, and nbgl_refreshUnicodeFont() prototype changed)

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • [*] New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

@nroggeman-ledger nroggeman-ledger force-pushed the remove-lang-dependency-from-nbgl branch 2 times, most recently from 285b5bf to bfa9d23 Compare August 21, 2024 09:48
@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 48.48485% with 17 lines in your changes missing coverage. Please review.

Project coverage is 60.34%. Comparing base (fddeb90) to head (87aa7fd).

Files Patch % Lines
lib_nbgl/src/nbgl_fonts.c 48.48% 17 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #750      +/-   ##
==========================================
+ Coverage   60.20%   60.34%   +0.13%     
==========================================
  Files          12       12              
  Lines        1729     1740      +11     
==========================================
+ Hits         1041     1050       +9     
- Misses        688      690       +2     
Flag Coverage Δ
unittests 60.34% <48.48%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nroggeman-ledger nroggeman-ledger merged commit e9b8b44 into master Aug 21, 2024
197 checks passed
@nroggeman-ledger nroggeman-ledger deleted the remove-lang-dependency-from-nbgl branch August 21, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants