Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flex/Stax: Progress bar fix #752

Merged
merged 2 commits into from
Aug 26, 2024
Merged

Conversation

abonnaudet-ledger
Copy link
Member

Description

Fix a progress bar glitch that occured when a modal was displayed over a progress bar.
Example:
Ledger Flex Review: Suspiciously Good!

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

Fix a progress bar glitch that appeared when a modal screen appeared on a progress bar.
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 59.88%. Comparing base (e26d098) to head (412adaf).

Files Patch % Lines
lib_nbgl/src/nbgl_obj.c 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #752      +/-   ##
==========================================
- Coverage   59.94%   59.88%   -0.06%     
==========================================
  Files          12       12              
  Lines        1710     1710              
==========================================
- Hits         1025     1024       -1     
- Misses        685      686       +1     
Flag Coverage Δ
unittests 59.88% <0.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abonnaudet-ledger abonnaudet-ledger merged commit 4141b77 into master Aug 26, 2024
197 checks passed
@abonnaudet-ledger abonnaudet-ledger deleted the abo_fix_progress_bar_glitch branch August 26, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants