Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick nbgl updates #762

Merged
merged 25 commits into from
Sep 6, 2024
Merged

Conversation

cedelavergne-ledger
Copy link
Contributor

@cedelavergne-ledger cedelavergne-ledger commented Sep 6, 2024

Description

Retrieve NBGL modifications from ledger-secure-sdk HEAD:

  • 66918cc: Update README.md
  • 05b51de: Update README.md
  • 8fc46ea: Fix missing lines in long tag/values, with no "More" button
  • b9fdc91: Add streaming Blind Signing Review Use Case
  • d3e71bc: Add non-streaming Blind Signing Review Use Case
  • 70b521c: Fix replacement of last char by "..." when using nbgl_textWrapOnNbLines()
  • 3cbbbda: Fix character loss in detail pairs with text wrapping enabled
  • 9536a33: Minor nbgl doc fixes
  • 8b41174: Flex/Stax: Progress bar drawing - add comments
  • bf4a739: Flex/Stax: Fix progress bar glitch
  • 4fe6a45: Rename and simplify object drawing API
  • cbbb6c1: Use array of functions to draw objects by types (more efficient)
  • 55e92fc: Fix missing PICs in NBGL Use Cases
  • 26a1cfd: Remove language dependency from NBGL
  • f33c799: Flex: Add nbgl masking syscall
  • 88279f0: Fix missing Tap To Continue in transactions
  • 5a10d3f: Automatic computation of number of items per settings page
  • 5039a6a: Add extended-center content to contain both centered info and tip-box
  • d2f584c: Create up-footer layout object to contain some types of objects
  • 350c27d: Improve rendering of some unicode & ASCII characters
  • e0944a0: Fix Russian unicode characters
  • af6592c: Fix German, Portuguese & Turkish unicode characters
  • 266a956: Fix Spanish & French unicode characters
  • 86c4bf0: FWEO-1214 make alphabet letters bold again lnsp lnx
  • 4c7e13f: Fix wrong highlighted app icon on Nano when this icon is compress

nroggeman-ledger and others added 25 commits September 6, 2024 17:19
(cherry picked from commit 3b5e79f)
(cherry picked from commit d497dc1)
(cherry picked from commit e311b5f)
Fix a progress bar glitch that appeared when a modal screen appeared on a progress bar.

(cherry picked from commit 7d7006b)
(cherry picked from commit ceee4d4)
(cherry picked from commit 5a0624d)
(cherry picked from commit 1c15d56)
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 59.81308% with 43 lines in your changes missing coverage. Please review.

Project coverage is 59.96%. Comparing base (603cf09) to head (66918cc).
Report is 24 commits behind head on API_LEVEL_21.

Files with missing lines Patch % Lines
lib_nbgl/src/nbgl_fonts.c 59.61% 21 Missing ⚠️
lib_nbgl/src/nbgl_obj.c 72.09% 12 Missing ⚠️
lib_nbgl/src/nbgl_screen.c 16.66% 10 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           API_LEVEL_21     #762      +/-   ##
================================================
- Coverage         60.19%   59.96%   -0.24%     
================================================
  Files                12       12              
  Lines              1726     1721       -5     
================================================
- Hits               1039     1032       -7     
- Misses              687      689       +2     
Flag Coverage Δ
unittests 59.96% <59.81%> (-0.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cedelavergne-ledger cedelavergne-ledger merged commit 8706d88 into API_LEVEL_21 Sep 6, 2024
195 checks passed
@cedelavergne-ledger cedelavergne-ledger deleted the cev/update_api_level_21 branch September 6, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants