Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix number of tag/values computation when the review is skippable #776

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

nroggeman-ledger
Copy link
Contributor

Description

The goal of this PR is to fix #775.
it consists in taking the "skippable" feature into account in the computation of the number of tag/values fitting in a page

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.67%. Comparing base (2661161) to head (11df65b).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #776   +/-   ##
=======================================
  Coverage   35.67%   35.67%           
=======================================
  Files          13       13           
  Lines        1595     1595           
=======================================
  Hits          569      569           
  Misses       1026     1026           
Flag Coverage Δ
unittests 35.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nroggeman-ledger nroggeman-ledger merged commit 1acfccd into master Sep 24, 2024
197 checks passed
@nroggeman-ledger nroggeman-ledger deleted the fix-nb-tag-values-when-skippable branch September 24, 2024 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix number of tag-value pairs displayed in a page for useCaseReviewStreamingContinueExt()
4 participants