Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full clang build for standard apps #793

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

apaillier-ledger
Copy link
Contributor

@apaillier-ledger apaillier-ledger commented Oct 7, 2024

Description

Now only uses clang for all steps of the build instead of the assembly of .S files and binary linking being delegated to GCC.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.76%. Comparing base (0bac17f) to head (6fc02aa).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #793   +/-   ##
=======================================
  Coverage   35.76%   35.76%           
=======================================
  Files          13       13           
  Lines        1591     1591           
=======================================
  Hits          569      569           
  Misses       1022     1022           
Flag Coverage Δ
unittests 35.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@apaillier-ledger
Copy link
Contributor Author

apaillier-ledger commented Oct 7, 2024

One point of attention is the branch instruction b from .S files is assembled differently

  • with GCC : b.n 2 (bytes)
  • with clang : b.w (4 bytes)

@apaillier-ledger apaillier-ledger marked this pull request as ready for review October 10, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants