Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INFRAPRJ-7379: Add arm64 host builder for 'ledgerhq/speculos' image #535

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

vbaskov-ledger
Copy link
Contributor

No description provided.

lpascal-ledger
lpascal-ledger previously approved these changes Dec 5, 2024
Copy link
Contributor

@lpascal-ledger lpascal-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's update the docker/build-push-action version like on the other workflow while we're at it, then 👍

.github/workflows/continuous-integration-workflow.yml Outdated Show resolved Hide resolved
@lpascal-ledger lpascal-ledger self-requested a review December 5, 2024 17:13
@lpascal-ledger
Copy link
Contributor

Except the Ci fails on a syntax error 🤔

@lpascal-ledger lpascal-ledger dismissed their stale review December 5, 2024 17:14

The CI fails

@vbaskov-ledger vbaskov-ledger force-pushed the INFRAPRJ-7379 branch 2 times, most recently from 142d5cd to a831358 Compare December 5, 2024 17:36
@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.86%. Comparing base (710f438) to head (54ad093).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #535   +/-   ##
=======================================
  Coverage   43.86%   43.86%           
=======================================
  Files         125      125           
  Lines       12448    12448           
  Branches      993      993           
=======================================
  Hits         5460     5460           
  Misses       6653     6653           
  Partials      335      335           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vbaskov-ledger vbaskov-ledger force-pushed the INFRAPRJ-7379 branch 3 times, most recently from c85b010 to 825ef26 Compare December 5, 2024 18:17
@lpascal-ledger lpascal-ledger merged commit 2ad969a into master Dec 6, 2024
43 checks passed
@lpascal-ledger lpascal-ledger deleted the INFRAPRJ-7379 branch December 6, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants