Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mecanum wheels handling in merged odometry #10

Merged
merged 12 commits into from
Aug 7, 2023
Merged

Mecanum wheels handling in merged odometry #10

merged 12 commits into from
Aug 7, 2023

Conversation

Bitterisland6
Copy link
Collaborator

@Bitterisland6 Bitterisland6 commented Jul 5, 2023

Added parameters and code required for mecanum wheels in merged odometry.

Signed-off-by: Bitterisland6 <bitterisland6@gmail.com>
@Bitterisland6 Bitterisland6 requested a review from bjsowa July 5, 2023 15:26
Signed-off-by: Bitterisland6 <bitterisland6@gmail.com>
@Bitterisland6 Bitterisland6 marked this pull request as draft July 7, 2023 15:13
@Bitterisland6 Bitterisland6 changed the title Mecanum wheels handling [WIP] Mecanum wheels handling Jul 7, 2023
@bjsowa bjsowa removed their request for review August 2, 2023 17:29
Signed-off-by: Aleksander Szymański <bitterisland6@gmail.com>
Signed-off-by: Aleksander Szymański <bitterisland6@gmail.com>
Signed-off-by: Aleksander Szymański <bitterisland6@gmail.com>
Signed-off-by: Aleksander Szymański <bitterisland6@gmail.com>
@Bitterisland6 Bitterisland6 changed the title [WIP] Mecanum wheels handling Mecanum wheels handling in merged odometry Aug 2, 2023
@Bitterisland6 Bitterisland6 marked this pull request as ready for review August 3, 2023 10:43
Comment on lines 12 to 23
diff_drive:
wheel_radius: 0.0625
wheel_separation: 0.33
angular_velocity_multiplier: 1.91
input_timeout: 500

mecanum_drive:
wheel_radius: 0.0635
wheel_separation: 0.405
wheel_base: 0.3052
angular_velocity_multiplier: 1.0
input_timeout: 500
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change these parameters to the defaults in the new firmware

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Signed-off-by: Aleksander Szymański <bitterisland6@gmail.com>
Signed-off-by: Aleksander Szymański <bitterisland6@gmail.com>
Signed-off-by: Aleksander Szymański <bitterisland6@gmail.com>
@bjsowa bjsowa merged commit 6111162 into master Aug 7, 2023
4 checks passed
@bjsowa bjsowa deleted the mecanum branch August 7, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants