Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump k6 version to 0.51.0 and go version to 1.21 #11

Merged
merged 2 commits into from
May 22, 2024
Merged

bump k6 version to 0.51.0 and go version to 1.21 #11

merged 2 commits into from
May 22, 2024

Conversation

kempsterc
Copy link
Contributor

@kempsterc kempsterc commented May 10, 2024

  • k6 version to 0.51.0
  • go version to 1.21 in CI

@kempsterc kempsterc marked this pull request as ready for review May 10, 2024 20:41
@kempsterc kempsterc changed the title bump k6 version to 0.50.0 and go version to 1.21 bump k6 version to 0.51.0 and go version to 1.21 May 13, 2024
@kempsterc
Copy link
Contributor Author

@LeonAdato would you mind reviewing please?

@LeonAdato
Copy link
Owner

@kempsterc sorry for the delay. I'm traveling and speaking at events this week and probably won't be able to review until early next week.

@kempsterc
Copy link
Contributor Author

Ah! Apologies.
At least I know now :). Thank you kindly!
No rush at all.
Just saw an opportunity to help

@LeonAdato LeonAdato self-assigned this May 16, 2024
Copy link
Collaborator

@javaducky javaducky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kempsterc appears good to me! Thanks!

Verified using the following steps:

  • Checkout branch using gh pr checkout 11
  • Build k6 with updated extension using make
  • Confirmed k6 version upgrade using ./k6 version
  • Start a StatsD target of a Graphite server using the Docker Compose file, docker compose up
  • Executed test script with new binary using ./k6 run -o output-statsd examples/ramping-vus.js
  • Confirmed in Graphite UI (http://localhost:80/) that updates were coming into the instance
  • Confirmed GitHub Actions from CI passed

@kempsterc
Copy link
Contributor Author

@kempsterc appears good to me! Thanks!

Verified using the following steps:

  • Checkout branch using gh pr checkout 11
  • Build k6 with updated extension using make
  • Confirmed k6 version upgrade using ./k6 version
  • Start a StatsD target of a Graphite server using the Docker Compose file, docker compose up
  • Executed test script with new binary using ./k6 run -o output-statsd examples/ramping-vus.js
  • Confirmed in Graphite UI (http://localhost:80/) that updates were coming into the instance

I followed the steps above, before I pushed

@kempsterc
Copy link
Contributor Author

@javaducky @LeonAdato can we merge this one please?
many thanks

@LeonAdato LeonAdato merged commit e1740f6 into LeonAdato:main May 22, 2024
4 checks passed
@nicholaspshaw
Copy link

@javaducky @LeonAdato is there a release planned for any time soon?

@kempsterc
Copy link
Contributor Author

@nicholaspshaw
probably needs
#12
then release

@LeonAdato
Copy link
Owner

I'm traveling home today but will review and merge tomorrow when I'm back at my desk.

Thank you for the help! ( And patience!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants