-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breaking: bump abstract-level
to 2.0.0
#52
Open
vweevers
wants to merge
18
commits into
main
Choose a base branch
from
v2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Feb 3, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 9f4fee2 - Browse repository at this point
Copy the full SHA 9f4fee2View commit details -
Configuration menu - View commit details
-
Copy full SHA for e179505 - Browse repository at this point
Copy the full SHA e179505View commit details -
Replace callbacks with promises
And `LEVEL_NOT_FOUND` with `undefined`. Passes the abstract test suite. Most other tests are commented out. The `iterator.next()` method required a small change: previously we had the callback signature `(err, entries, finished)` where "finished" meant "reached the end of the data". Now we have a promise for only `entries`. So an extra `next()` call (end-to-end) is now needed to know that the end was reached.
Configuration menu - View commit details
-
Copy full SHA for 5d62647 - Browse repository at this point
Copy the full SHA 5d62647View commit details -
Configuration menu - View commit details
-
Copy full SHA for df393c7 - Browse repository at this point
Copy the full SHA df393c7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2b3419d - Browse repository at this point
Copy the full SHA 2b3419dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1d6a329 - Browse repository at this point
Copy the full SHA 1d6a329View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8eb73fd - Browse repository at this point
Copy the full SHA 8eb73fdView commit details -
Configuration menu - View commit details
-
Copy full SHA for fb7273a - Browse repository at this point
Copy the full SHA fb7273aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 01c2a2d - Browse repository at this point
Copy the full SHA 01c2a2dView commit details -
Create snapshot for
get()
synchronouslyHas a tiny performance cost, which I negated by optimizing the passing of options from JS to C++. The end result is faster than before. However, I didn't check if it blocks the event loop for a significant amount of time. Benchmarking concurrent gets might answer that, later. Ref Level/community#118.
Configuration menu - View commit details
-
Copy full SHA for b4404b3 - Browse repository at this point
Copy the full SHA b4404b3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 551b5f7 - Browse repository at this point
Copy the full SHA 551b5f7View commit details -
Configuration menu - View commit details
-
Copy full SHA for b064215 - Browse repository at this point
Copy the full SHA b064215View commit details -
Configuration menu - View commit details
-
Copy full SHA for 72000a0 - Browse repository at this point
Copy the full SHA 72000a0View commit details
Commits on Feb 4, 2024
-
Update README, with a new approach
Instead of copying abstract-level docs and then tweaking it for classic-level (on every release, which was a bit of a pain) the README now only describes the differences.
Configuration menu - View commit details
-
Copy full SHA for c5a092d - Browse repository at this point
Copy the full SHA c5a092dView commit details -
Configuration menu - View commit details
-
Copy full SHA for e7e2763 - Browse repository at this point
Copy the full SHA e7e2763View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6b7b282 - Browse repository at this point
Copy the full SHA 6b7b282View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9a2d9d9 - Browse repository at this point
Copy the full SHA 9a2d9d9View commit details -
Configuration menu - View commit details
-
Copy full SHA for bd9b30a - Browse repository at this point
Copy the full SHA bd9b30aView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.