fix(mkfile): attempt #2 to fix dynamic lib creation linking issues wi…

…th windows clang ld-link
LexouDuck · Nov 22, 2024 · 5cfb6a7 · 5cfb6a7
1 parent 03afca8
commit 5cfb6a7
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/VERSION b/VERSION
@@ -1 +1 @@
-libccc@0.12.2-2024-11-22_ef9d53dad84d11b270a961fc5b50348a2dd8bac1
+libccc@0.12.3-2024-11-22_03afca8e7946540529c1d4213fe38049d4fb7981
diff --git a/mkfile/rules/build.mk b/mkfile/rules/build.mk
@@ -124,9 +124,7 @@ endif
 ifeq ($(OSMODE),windows)
 ifeq ($(CC),clang)
 	@$(CC) -shared -o $@ $(CFLAGS) $(LDFLAGS) $(call objs) $(LDLIBS) \
-		-Wl,-export-all-symbols \
-		-fvisibility=
-	@ls -al $(BINPATH)dynamic/
+		-fvisibility=default
 else
 	@$(CC) -shared -o $@ $(CFLAGS) $(LDFLAGS) $(call objs) $(LDLIBS) \
 		-Wl,--output-def,$(BINPATH)dynamic/$(NAME).def \
@@ -136,9 +134,9 @@ endif
 endif
 ifeq ($(OSMODE),emscripten)
 	@$(CC) -o $@ $(CFLAGS) $(LDFLAGS) $(call objs) $(LDLIBS) \
-		-s MODULARIZE \
 		-s EXPORTED_FUNCTIONS=[_JSON_FromString_Lenient,_JSON_ToString_Minify,_KVT_Delete] \
-		-s EXPORTED_RUNTIME_METHODS=[ccall,cwrap,getValue,setValue,stringToUTF8,UTF8ToString,lengthBytesUTF8]
+		-s EXPORTED_RUNTIME_METHODS=[ccall,cwrap,getValue,setValue,stringToUTF8,UTF8ToString,lengthBytesUTF8] \
+		-s MODULARIZE
 endif
 	@printf $(IO_GREEN)"OK!"$(IO_RESET)"\n"
 	@$(call bin_copylibs,dynamic)
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		libccc@0.12.2-2024-11-22_ef9d53dad84d11b270a961fc5b50348a2dd8bac1
		libccc@0.12.3-2024-11-22_03afca8e7946540529c1d4213fe38049d4fb7981