Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search only the Boost Graph Library component #187

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

wolodyx
Copy link
Contributor

@wolodyx wolodyx commented Jun 13, 2024

Only some boost packages can be installed on the computer. If only boost-program-options is available, then the program will not build: HAS_BOOST will be TRUE, but the header file "boost/adjacency_list.hpp" will not be available. My little edit corrects this situation.

@LiangliangNan
Copy link
Owner

LiangliangNan commented Jun 13, 2024

Hi, thanks for this pull request.

I want to understand what the issue was. What does "Only some boost packages can be installed on the computer" mean?

After checking your edit, I see the only change is
find_package(Boost)
to
find_package(Boost COMPONENTS graph)
Now I realize that only the boost "graph" module is needed.

@LiangliangNan LiangliangNan merged commit e3705d9 into LiangliangNan:main Jun 13, 2024
6 checks passed
@LiangliangNan
Copy link
Owner

I have merged your edit into the code.
Thanks again for the contribution!

@wolodyx
Copy link
Contributor Author

wolodyx commented Jun 14, 2024

Hi, thanks for this pull request.

I want to understand what the issue was. What does "Only some boost packages can be installed on the computer" mean?

After checking your edit, I see the only change is find_package(Boost) to find_package(Boost COMPONENTS graph) Now I realize that only the boost "graph" module is needed.

Hi! Thank you for accepting this code.
On my machine, I installed only a separate boost-program-options module from the boost package. Because of this, Easy3d was not going to, because "algo/CMakeLists.txt "found boost (set HAS_BOOST=TRUE), but couldn't find "boost/adjacency_list.hpp". This resulted in a compilation error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants