-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DIP-267 Provide a User Data mechanism for links to profiles #277
Merged
Merged
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
# Migrated Announcements | ||
|
||
* [Graph Change](Types/GraphChange.md) | ||
* [Graph Change](Types/GraphChange.md) | ||
* [Profile](Types/Profile.md) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,56 @@ | ||
# ProfileResource | ||
|
||
A profile-linked resource is represented by the ProfileResource object type. | ||
|
||
## Serialization | ||
|
||
ProfileResource object serialization MUST conform to the following [Avro](https://avro.apache.org) schema: | ||
|
||
``` | ||
{ | ||
"namespace": "org.dsnp", | ||
"name": "ProfileResource", | ||
"type": "record", | ||
"doc": "Profile-linked resource", | ||
"fields": [ | ||
{ | ||
"name": "type", | ||
"type": "int", | ||
"doc": "Type of resource" | ||
}, | ||
{ | ||
"name": "cid", | ||
"type": "string", | ||
wilwade marked this conversation as resolved.
Show resolved
Hide resolved
|
||
"doc": "Content IDentifier of resource" | ||
}, | ||
{ | ||
"name": "length", | ||
"type": "int", | ||
"doc": "Length of document in bytes" | ||
} | ||
] | ||
} | ||
``` | ||
|
||
## Generation | ||
|
||
### type | ||
|
||
- MUST be a supported DSNP profile-linked resource type. | ||
|
||
#### Supported Profile-Linked Resource Types | ||
|
||
| Value | Description | Specification | Content Type | DSNP Version Added | | ||
| --- | --- | --- | --- | | ||
| 1 | Activity Content Profile with DSNP extensions | [DSNP Profile](../../ActivityContent/Types/Profile.md) | `application/json` | 1.3 | | ||
|
||
All other document type values are reserved for future expansion. | ||
|
||
### cid | ||
|
||
- MUST be a valid [DSNP CID](../Identifiers.md#dsnp-cid] | ||
|
||
### length | ||
|
||
- MUST be a positive integer | ||
- MUST match the length in bytes of the document |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this change should also propagate to
pages/ActivityContent/Associated/Hash.md
Or would that require #273 to be implemented first?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is just changing it to a multihash multibase string, as we don't serialize hashes as hex anywhere as far as I know. (The DSNP URI should match the hash from the announcement, which is now a multihash.)
Technically unrelated to the purpose of this PR, just a vestigial issue I happened to run into. I can make it a separate PR if you think it's warranted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is fine. Just checking