Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved all javascript scripts on the asset detail page to their own files. #2479

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

joshuastegmaier
Copy link
Collaborator

@joshuastegmaier joshuastegmaier commented Aug 2, 2024

http://staff.loc.gov/tasks/browse/CONCD-896

This is the first step in the refactoring. All JavaScript scripts are moved out into their own files. The JS isn't in its final state, since everything is just dumped into the global context, but this gets them out of asset_details.html, reducing the lines in the file by about a third.

@joshuastegmaier joshuastegmaier marked this pull request as ready for review August 2, 2024 18:29
@jkueloc jkueloc merged commit ef5e3d9 into main Aug 2, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants