Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split asset_detail.html template into smaller templates. Re-added a JS function that was needed. #2481

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Split asset_detail.html template into smaller templates. Re-added a JS function that was needed. #2481

merged 1 commit into from
Aug 6, 2024

Conversation

joshuastegmaier
Copy link
Collaborator

rasarkar
rasarkar approved these changes Aug 5, 2024
View reviewed changes
Copy link
Collaborator

@rasarkar rasarkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somewhat related: we should probably rename quick_tips_modal to campaign_tips_modal.

@joshuastegmaier
Copy link
Collaborator Author

I actually decided against doing that since quick tips is used elsewhere. We can continue using that name in the code for the feature.

@jkueloc
Copy link
Collaborator

jkueloc commented Aug 6, 2024

@joshuastegmaier This is still marked as a draft...?

@joshuastegmaier joshuastegmaier marked this pull request as ready for review August 6, 2024 12:26
@joshuastegmaier
Copy link
Collaborator Author

Just didn't hit the button when the checks all finished. Sorry!

@jkueloc jkueloc merged commit c93ec4c into main Aug 6, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rasarkar rasarkar rasarkar approved these changes

Assignees

@jkueloc jkueloc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshuastegmaier @jkueloc @rasarkar