Encapsulate the asset_details.html scripts #2491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g those to the module. Moved guide template to live with the rest of the asset_detail sub-templates. Reorganized guide.js slightly and removed unused code. Changed eslint configurations to handle modules
…med existing quick-tips.js to quick-tips-setup.js to reflect what it does, and modified to use the modules/quick-tips.js module.. Modified base.html quick-tips code to use the module. Modified tempalte to hide 'Campaign Tips' link/button for campaigns that don't have any cards.
…ne onclick handler for select language to be in ocr.js
…data for asset-reservation.js to separate script element to allow access from within the module--passing it directly to the script tag of a module does not work like it does for a normal script.
…r.js to separate script element to allowing access to the data in the module. Moved inline onclick handlers for viewer image filters into click handlers in viewer.js
…split.js import to viewer-split.js and removed script tag for it.
rasarkar
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a lot of small changes, but the overall change is making sure all of our scripts on the asset detail page are encapsulated. All inline calls to JavaScript (onclick) were changed to use event listeners instead.
Additionally, I was able to use Split.js as a module, but unfortunately it wasn't possible to do with OpenSeadragon or OpenSeadragon Filters.
Some globals are still being used from scripts like base.js. Modularizing that is a future ticket, since it touches a lot of places in the site.