Added bypass for retrieving the turnstile secrets. #2531
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntext processor to its own file. Removed redundant/unused context processor
|
We don't need this anymore since the secrets permissions have been updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also a couple of changes I meant to make earlier:
Moved turnstile context processor to its own file.
Removed redundant/unused context processor
The try/except/pass block is a possible security issue because it can hide errors caused by an attack, but in this case I just bypassed the Bandit test for it since it is a temporary measure (and I believe with this usage it wouldn't actually be a potential security risk anyway). The fix would be catch the specific exceptions being raised, but those are just normal Exceptions anyway, so that would require rewriting the secrets code to raise different exceptions.