Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trac#18139 Importieren von Formularinhalten #324

Open
wants to merge 1 commit into
base: WollMux_18.2
Choose a base branch
from
Open

trac#18139 Importieren von Formularinhalten #324

wants to merge 1 commit into from
+268 −3

Conversation

ilhany359
Copy link
Contributor

No description provided.

sikelerd
sikelerd suggested changes Nov 20, 2020
View reviewed changes
Copy link
Contributor

@sikelerd sikelerd left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Die Daten werden mit dem Event OnSetFormValue ins Dokument und die Sidebar propagiert. Die Daten nur in die Map zu schreiben ändert zwar den internen Zustand aber nicht die anzeige. Es sollte auf jeden Fall in der Aufrufkette irgendwann mal FormModel.setValue(string, string) verwendet werden.

Bitte auch die Sonar-Warnings beheben.

core/src/main/java/de/muenchen/allg/itd51/wollmux/event/handlers/OnImportFormularinhalt.java Outdated Show resolved Hide resolved
core/src/main/java/de/muenchen/allg/itd51/wollmux/event/handlers/OnImportFormularinhalt.java Outdated Show resolved Hide resolved
@ilhany359 ilhany359 force-pushed the importFormularinhalte branch 2 times, most recently from ef6e3ad to 1dd3e87 Compare November 26, 2020 13:03
sikelerd
sikelerd suggested changes Dec 1, 2020
View reviewed changes
Copy link
Contributor

@sikelerd sikelerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bitte die Sonar-Warnings noch beheben:
http://kvm-javabuild.tvc.muenchen.de/sonar/project/issues?branch=PR-324&id=de.muenchen%3Awollmux&resolved=false&types=CODE_SMELL

core/src/main/java/de/muenchen/allg/itd51/wollmux/document/TextDocumentModel.java Outdated Show resolved Hide resolved
core/src/main/java/de/muenchen/allg/itd51/wollmux/form/control/FormController.java Outdated Show resolved Hide resolved
core/src/main/java/de/muenchen/allg/itd51/wollmux/form/control/FormController.java Outdated Show resolved Hide resolved
core/src/main/java/de/muenchen/allg/itd51/wollmux/event/handlers/OnImportFormularinhalt.java Outdated Show resolved Hide resolved
@ilhany359 ilhany359 force-pushed the importFormularinhalte branch 2 times, most recently from cca87b3 to ccbca3e Compare December 7, 2020 08:14
@ilhany359
Copy link
Contributor Author

Die SonarLint Warnung: Refactor this method to reduce its Cognitive Complexity from 18 to the 15 allowed: Das habe ich von 24 auf 18 reduzieren können. Wie ich es weiter reduzieren kann, ist mir nicht klar, und ob der Code dann wirklich lesbarer wird?

@ilhany359 ilhany359 closed this Dec 10, 2020
@ilhany359 ilhany359 reopened this Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sikelerd sikelerd sikelerd requested changes

@bjoernranft bjoernranft Awaiting requested review from bjoernranft

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ilhany359 @sikelerd