Translated Comments from German to English #474
Conversation
|
I had changed the comments on the GitHub itself, so you can ignore the checks as no single line of code was changed apart from the German comments. @thorstenb @smehrbrodt Please review the same and merge it. Thanks. |
| * entferne alle anderen Sternchen. Ein Punkt am Ende eines Wortes wird als Abkürzung | ||
| * interpretiert und durch Sternchen ersetzt. | ||
| /** | ||
| * Only a single asterisk at the end of a word is accepted by the user. Therefore, remove all other asterisks. |
There was a problem hiding this comment.
is accepted by the user
I think this should be something like "is allowed as user input".
| * Takes a template for a search query (which may contain variables of the form "${suchanfrageX}") | ||
| * and instantiates it with words from words, considering only the first wordcount | ||
| * entries of words. |
There was a problem hiding this comment.
"suchanfrageX" should also be translated, such as "searchqueryX".
instantiates it with words from words
That's difficult to parse in English - in German you knew that the English term refers to the variable name, but in pure English that context gets lost. How about "instantiates it with a list of words"?
| */ | ||
|
|
There was a problem hiding this comment.
There are several additional newlines in this pull request without any obvious pattern when they are added and when they are skipped...
| * Note: The following condition is "unnecessarily" strict, | ||
| * but to relax it (e.g., the overall schema is the union of the schemas) | ||
| * it would be necessary to implement a dataset wrapper that ensures that | ||
| * all datasets returned in query results have the same schema. |
There was a problem hiding this comment.
query results
This should be QueryResults.
Pull Request: Translation of German Comments to English
Overview
This pull request (PR) addresses the issue of German comments found in various source files within the LibreOffice repository. The primary goal is to translate these comments into English to enhance code readability and maintainability for all contributors.
Files Translated
The following files have been updated with translated comments:
core/src/main/java/org/libreoffice/lots/db/SchemaDatasource.javacore/src/main/java/org/libreoffice/lots/db/Search.javacore/src/main/java/org/libreoffice/lots/db/SearchStrategy.javacore/src/main/java/org/libreoffice/lots/db/SimpleDataset.javacore/src/main/java/org/libreoffice/lots/db/ThingyDatasource.javacore/src/main/java/org/libreoffice/lots/db/UnionDatasource.javaSummary of Changes
Why This Change?
Translating comments to English is crucial for:
Related Issues