Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for MCUboot and enable it for BMS C1 #72

Merged
merged 3 commits into from
Jun 19, 2024
Merged

Add support for MCUboot and enable it for BMS C1 #72

merged 3 commits into from
Jun 19, 2024

Conversation

martinjaeger
Copy link
Member

@martinjaeger martinjaeger commented Jun 1, 2024 •
edited
Loading

As the title suggests, this PR adds support for DFU with MCUboot.

So far only enabled for the BMS C1.

See the docs updates on instructions how to test it.

Depends on ThingSet/thingset-zephyr-sdk#48

@martinjaeger martinjaeger mentioned this pull request Jun 13, 2024
Merged
@martinjaeger
Reduce board _defconfig files to the bare minimum
3cc786b 
This is a preparation to use MCUboot, which doesn't need peripherals
like CAN or the BMS IC drivers.

Kconfig selection has to be moved to the app/boards folder.
@martinjaeger martinjaeger marked this pull request as ready for review June 14, 2024 09:43
@martinjaeger martinjaeger requested a review from pasrom June 14, 2024 09:45
pasrom
pasrom reviewed Jun 17, 2024
View reviewed changes
Copy link
Collaborator

@pasrom pasrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me. I'd like to test them on my setup this week. Is that okay with you?

@martinjaeger
Copy link
Member Author

Sure. No hurry from my side.

Let me know if everything worked well and if the documentation was sufficient.

@pasrom
Copy link
Collaborator

pasrom commented Jun 19, 2024

I did test it and encountered two problems:

  1. west espressif monitor does not work anymore from the app folder (inside app/build/app it works).
  2. The update script does not receive the 0x84 after the reboot function is called, because the processor is already rebooting, so dfu: Refactor reboot process using delayed work item ThingSet/thingset-zephyr-sdk#50 should resolve it.

@martinjaeger
Copy link
Member Author

  1. west espressif monitor does not work anymore from the app folder (inside app/build/app it works).

Ah, interesting. I just noticed it doesn't work anymore (but didn't associate it with sysbuild) and updated the documentation accordingly. I'm using picocom all the time anyway and didn't want to dig deeper why espressif monitor stopped working.

@martinjaeger
Copy link
Member Author

@pasrom I have updated the commit sha in west.yml to pull in your fixes for 2.

pasrom
pasrom approved these changes Jun 19, 2024
View reviewed changes
Copy link
Collaborator

@pasrom pasrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀🎉
Thank you for adding this feature!

@martinjaeger martinjaeger merged commit ce8b876 into main Jun 19, 2024
2 checks passed
@martinjaeger martinjaeger deleted the mcuboot-support branch June 19, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pasrom pasrom pasrom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martinjaeger @pasrom