[BOOKINGSG-4633][SR] Refactor code with PR comments

LifeSG · Sep 5, 2023 · 4e11567 · 4e11567
1 parent d6cbe7b
commit 4e11567
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/src/data-table/data-table.styles.tsx b/src/data-table/data-table.styles.tsx
@@ -98,10 +98,10 @@ export const BodyRow = styled.tr<BodyRowProps>`
     }};
     border-top: 1px solid ${borderColor};
     &:hover {
-        background-color: ${(props) => {
+        ${(props) => {
             if (!props.$isSelected && props.$isSelectable) {
                 return css`
-                    ${DesignToken.Table.Cell.Hover};
+                    background-color: ${DesignToken.Table.Cell.Hover};
                 `;
             }
         }};
@@ -113,8 +113,6 @@ export const BodyCell = styled.td<BodyCellProps>`
         props.$isCheckbox ? "1.25rem 0.5rem 1.25rem 1.5rem" : "1.25rem 1rem"};
     vertical-align: middle;
     color: ${fontColor};
-    min-height: 2.625rem;
-    max-height: 5.75rem;
 `;
 
 export const BodyCellContent = styled(Text.Body)`

diff --git a/src/data-table/data-table.tsx b/src/data-table/data-table.tsx
@@ -193,7 +193,7 @@ export const DataTable = ({
                 {typeof cellData === "string" ? (
                     <BodyCellContent>{cellData}</BodyCellContent>
                 ) : (
-                    { cellData }
+                    cellData
                 )}
             </BodyCell>
         );

diff --git a/src/error-display/types.ts b/src/error-display/types.ts
@@ -1,3 +1,5 @@
+import { ButtonProps } from "../button";
+
 export type ErrorDisplayType =
     | "400"
     | "403"
@@ -30,7 +32,7 @@ export interface ErrorDisplayAttributes {
     title?: string | JSX.Element | undefined;
     description?: string | JSX.Element | undefined;
     /** The action button displayed at the bottom of the Error Display */
-    actionButton?: React.ButtonHTMLAttributes<HTMLButtonElement> | undefined;
+    actionButton?: ButtonProps | undefined;
     additionalProps?: MaintenanceAdditionalAttributes | undefined;
 }