Handle cleared and invalid date values #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qroll
commented
Aug 30, 2023
| @@ -31,4 +28,14 @@ export namespace DateInputHelper { | |||
|
|
|||
| return false; | |||
| }; | |||
|
|
|||
| export const sanitizeInput = (date: string): string => { | |||
There was a problem hiding this comment.
this helps to convert invalid date strings like "2023-x-x" to an empty string (i.e. those values get ignored)
qroll
commented
Aug 30, 2023
| @@ -80,4 +80,8 @@ export namespace DateHelper { | |||
| const endTime = dayjs(end, format); | |||
| return endTime.diff(startTime, "minute"); | |||
| }; | |||
|
|
|||
| export const toDayjs = (date: string): Dayjs => { | |||
There was a problem hiding this comment.
to circumvent the behaviour where dayjs("") results in invalid day instead of returning the current day like dayjs(undefined)
keithtxw
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #294
Changes
Changelog entry
Bug fixes
DateInputandDateRangeInput