Hide nav branding and adjust navbar styles #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keithtxw
reviewed
Sep 22, 2023
src/navbar/navbar-items.tsx
Outdated
| @@ -119,8 +121,9 @@ export const NavbarItems = <T,>({ | |||
| selectedIndex >= 0 && | |||
| selectedIndex === index && | |||
| showSubMenu; | |||
| const alignLeft = index === 0 && hideNavBranding; | |||
There was a problem hiding this comment.
Since we are already restricting only the first child to have the align left, this check is redundant? On the same note, then maybe can have a generic prop called $hiddenBranding or something
qroll
force-pushed
the
hide-nav-branding
branch
from
82bf200 to
68952b5
Compare
keithtxw
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
hideNavBrandingto hide brand logos in navbar and drawer. Nav items will be aligned to the left.Changelog entry
hideNavBrandingprop to hide brand logos inNavbar