Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix navbar unintended hamburger #317

Merged
merged 3 commits into from
Sep 25, 2023
Merged

Conversation

keithtxw
Copy link
Contributor

Changes

  • Fix unintended appearance of mobile menu icon even if no items or action buttons are specified

  • Added some basic tests

  • [delete] branch

Changelog entry

  • Fix Navbar mobile menu button appearing even if no items or action buttons are specified

Additional information

  • You may refer to this ticket

@keithtxw keithtxw requested a review from qroll September 22, 2023 02:07
src/navbar/navbar.tsx Outdated Show resolved Hide resolved
@qroll qroll added this to the v2.2.0-canary.1 milestone Sep 22, 2023
@qroll qroll added the bug Something isn't working label Sep 22, 2023
@qroll qroll merged commit 319759b into master Sep 25, 2023
1 check passed
@qroll qroll deleted the fix-navbar-unintended-hamburger branch January 3, 2024 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants