Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BOOKINGSG-6086][JH] add optional timestamp prop for CountdownTimer #544

Merged
merged 2 commits into from
Aug 23, 2024
Merged

[BOOKINGSG-6086][JH] add optional timestamp prop for CountdownTimer #544

merged 2 commits into from
Aug 23, 2024

Conversation

jhyeep
Copy link

@jhyeep jhyeep commented Aug 22, 2024

Changes
Add optional timestamp prop for CountdownTimer. timestamp signifies the time at which the countdown should end, and takes precedence over timer

  • delete branch

Changelog entry

  • Add optional timestamp prop for CountdownTimer component

Additional information

@jhyeep jhyeep requested a review from weili-govtech August 22, 2024 05:54
@jhyeep jhyeep self-assigned this Aug 22, 2024
weili-govtech
weili-govtech requested changes Aug 22, 2024
View reviewed changes
src/countdown-timer/types.ts Outdated Show resolved Hide resolved
src/countdown-timer/use-timer.tsx Outdated Show resolved Hide resolved
@jhyeep jhyeep requested a review from weili-govtech August 23, 2024 03:41
@weili-govtech weili-govtech added this to the v2.7.0-canary.6 milestone Aug 23, 2024
@weili-govtech weili-govtech merged commit 36da259 into master Aug 23, 2024
1 check passed
@weili-govtech weili-govtech deleted the countdown-timer-timestamp branch August 23, 2024 07:18
@weili-govtech weili-govtech added the enhancement New feature or request label Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weili-govtech weili-govtech weili-govtech approved these changes

Assignees

@jhyeep jhyeep

Labels
enhancement New feature or request
Projects
None yet
Milestone
v2.7.0-canary.6
Development

Successfully merging this pull request may close these issues.
2 participants
@jhyeep @weili-govtech