Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BOOKINGSG-6086][JH] Adjust CountdownTimer logic to improve accuracy for timestamp #549

Merged
merged 3 commits into from
Aug 29, 2024
Merged

[BOOKINGSG-6086][JH] Adjust CountdownTimer logic to improve accuracy for timestamp #549

merged 3 commits into from
Aug 29, 2024

Conversation

jhyeep
Copy link

@jhyeep jhyeep commented Aug 28, 2024 •
edited
Loading

Changes

  • Changed CountdownTimer logic from a regular setInterval to setTimeout, to dynamically adjust the delay between executions based on drift time

  • Also fixed a typo in the storybook props table for Filter. toggleFilterButtonStyle was incorrectly named as toggleFilterButtonType

  • [delete] branch

Additional information

@jhyeep jhyeep requested a review from weili-govtech August 28, 2024 05:45
@jhyeep jhyeep self-assigned this Aug 28, 2024
@weili-govtech weili-govtech added the bug Something isn't working label Aug 28, 2024
@weili-govtech weili-govtech added this to the v2.7.0-canary.7 milestone Aug 28, 2024
@jhyeep jhyeep changed the title [BOOKINGSG-6086][JH] Adjust CountdownTimer logic from Math.ceil to floor [BOOKINGSG-6086][JH] Adjust CountdownTimer logic to improve accuracy for timestamp Aug 29, 2024
@weili-govtech weili-govtech merged commit 93c4310 into master Aug 29, 2024
1 check passed
@weili-govtech weili-govtech deleted the countdown-timer-accuracy branch August 29, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weili-govtech weili-govtech weili-govtech approved these changes

Assignees

@jhyeep jhyeep

Labels
bug Something isn't working
Projects
None yet
Milestone
v2.7.0-canary.7
Development

Successfully merging this pull request may close these issues.
2 participants
@jhyeep @weili-govtech