Layout component - coldiv. #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ok and add theme capability for Layout component
mahidhar-reddy09
force-pushed
the
layout-coldiv
branch
from
5252585 to
440c943
Compare
qroll
requested changes
Oct 10, 2024
…e margin and padding for grid children
qroll
requested changes
Oct 10, 2024
qroll
reviewed
Oct 10, 2024
qroll
reviewed
Oct 13, 2024
qroll
requested changes
Oct 15, 2024
src/layout/col-div.tsx
Outdated
Comment on lines
73
to
79
| xxlColumnCount || | ||
| xlColumnCount || | ||
| lgColumnCount || | ||
| mdColumnCount || | ||
| smColumnCount || | ||
| xsColumnCount || | ||
| xxsColumnCount, |
There was a problem hiding this comment.
column count doesn't need a fallback as it's static (based on the theme)
qroll
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set up layout component- coldiv.