Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BOOKINGSG-6090-timetable][JZ|FY] Added TimeTable component and enhanced popover #581

Merged
merged 18 commits into from
Oct 9, 2024

Conversation

xyukianesa
Copy link

Changes

  • Added TimeTable component

  • [delete] branch

Changelog entry
Added TimeTable component to facilitate listing displays and its statuses across a time range, with lazy loading, empty content, custom popovers, and click functionalities.
Updated Popover to allow offset/delay props to be customisable, defaults to the existing fixed values of offset=16, delay={open:0, close: 500}.

Additional information

@qroll qroll changed the base branch from master to BOOKINGSG-6090-date-navigator September 26, 2024 06:59
Copy link
Contributor

@qroll qroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some initial comments on the component interface

src/popover-v2/popover-trigger.tsx Outdated Show resolved Hide resolved
src/popover-v2/types.ts Outdated Show resolved Hide resolved
src/timetable/types.ts Outdated Show resolved Hide resolved
src/timetable/types.ts Show resolved Hide resolved
src/timetable/types.ts Outdated Show resolved Hide resolved
src/timetable/types.ts Outdated Show resolved Hide resolved
src/timetable/types.ts Outdated Show resolved Hide resolved
src/timetable/types.ts Outdated Show resolved Hide resolved
src/timetable/types.ts Outdated Show resolved Hide resolved
src/timetable/types.ts Outdated Show resolved Hide resolved
stories/timetable/timetable-data-even-days.json Outdated Show resolved Hide resolved
src/timetable/types.ts Outdated Show resolved Hide resolved
Base automatically changed from BOOKINGSG-6090-date-navigator to master October 3, 2024 05:22
@xyukianesa xyukianesa requested a review from qroll October 4, 2024 05:52
src/timetable/types.ts Outdated Show resolved Hide resolved
src/timetable/types.ts Outdated Show resolved Hide resolved
src/timetable/types.ts Outdated Show resolved Hide resolved
src/timetable/types.ts Outdated Show resolved Hide resolved
src/timetable/timetable.tsx Outdated Show resolved Hide resolved
src/timetable/timetable-navigator/timetable-navigator.tsx Outdated Show resolved Hide resolved
src/timetable/timetable-navigator/timetable-navigator.tsx Outdated Show resolved Hide resolved
src/timetable/timetable-navigator/timetable-navigator.tsx Outdated Show resolved Hide resolved
@xyukianesa xyukianesa requested a review from qroll October 8, 2024 09:08
@qroll qroll added this to the v2.8.0-canary.3 milestone Oct 9, 2024
@qroll qroll added the enhancement New feature or request label Oct 9, 2024
@qroll qroll merged commit 1828bb2 into master Oct 9, 2024
1 check passed
@qroll qroll deleted the BOOKINGSG-6090-timetable branch October 9, 2024 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants