Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow uneditable section to stretch full width #589

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

qroll
Copy link
Contributor

@qroll qroll commented Oct 8, 2024

Changes

The UneditableSection is rendered in a Layout.Content grid and the content takes up 8 columns on desktop by default. This makes sense when rendered as a top-level section in a page, but not when inside of another container such as the accordion box.

This PR adds a prop to let content take up the full columns on desktop

  • [delete] branch

Changelog

  • Allow UneditableSection to stretch full width

@qroll qroll requested a review from weili-govtech October 9, 2024 00:17
@qroll qroll marked this pull request as ready for review October 9, 2024 00:17
@qroll qroll force-pushed the uneditable-section-width branch from 212b7cf to 5900305 Compare October 9, 2024 00:43
@weili-govtech weili-govtech merged commit d6a0169 into master Oct 9, 2024
1 check passed
@weili-govtech weili-govtech deleted the uneditable-section-width branch October 9, 2024 05:44
@qroll qroll added the enhancement New feature or request label Oct 9, 2024
@qroll qroll added this to the v2.8.0-canary.3 milestone Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants