Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MOL-16700][AM] Add local nav dropdown and local nav menu components #605

Merged
merged 44 commits into from
Nov 20, 2024
Merged

[MOL-16700][AM] Add local nav dropdown and local nav menu components #605

merged 44 commits into from
Nov 20, 2024

Conversation

AnuMutyala
Copy link

Changes
Add local nav dropdown and local nav menu components

  • [delete] branch

Changelog entry

  • Add local nav dropdown and local nav menu components

Additional information

@AnuMutyala AnuMutyala self-assigned this Oct 25, 2024
@AnuMutyala AnuMutyala requested a review from qroll October 25, 2024 09:38
@AnuMutyala AnuMutyala marked this pull request as draft October 25, 2024 09:38
@AnuMutyala AnuMutyala marked this pull request as ready for review October 28, 2024 11:35
@qroll
Copy link
Contributor

qroll commented Nov 1, 2024

  • match the DS conventions
  • move out internally used types from types.ts
  • proposed adjustments to the interface:
BaseLocalNavProps
  items: LocalNavItemProps[]
  selectedItemIndex: number
  onNavItemSelect: (e: React.MouseEvent, item: LocalNavItemProps, index: number) => void
  renderItem: (item: LocalNavItemProps, renderProps: {selected: boolean}) => React.ReactNode

LocalNavMenuProps

LocalNavDropdownProps
   defaultLabel: string | React.ReactNode
   stickyOffset?: number

LocalNavItemProps
  id?: string
  label: string | React.ReactNode

@qroll qroll added the enhancement New feature or request label Nov 1, 2024
@qroll qroll modified the milestones: v2.8.0-canary.5, v2.8.0-canary.6 Nov 1, 2024
@AnuMutyala AnuMutyala requested a review from qroll November 7, 2024 09:25
@AnuMutyala AnuMutyala marked this pull request as draft November 7, 2024 10:00
@AnuMutyala AnuMutyala marked this pull request as ready for review November 8, 2024 02:32
qroll
qroll requested changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@qroll qroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as discussed, some of the redundant css can be cleaned up

src/local-nav/local-nav-menu/local-nav-menu.tsx Outdated Show resolved Hide resolved
src/local-nav/local-nav-dropdown/local-nav-dropdown.tsx Outdated Show resolved Hide resolved
src/local-nav/local-nav-dropdown/local-nav-dropdown.styles.tsx Outdated Show resolved Hide resolved
src/local-nav/local-nav-dropdown/local-nav-dropdown.styles.tsx Outdated Show resolved Hide resolved
@AnuMutyala AnuMutyala requested a review from qroll November 14, 2024 04:35
@AnuMutyala AnuMutyala requested a review from qroll November 18, 2024 14:57
@qroll
Copy link
Contributor

qroll commented Nov 19, 2024

missing horizontal spacing on mobile

Screenshot 2024-11-19 at 1 29 05 PM

@AnuMutyala AnuMutyala requested a review from qroll November 19, 2024 09:01
@qroll qroll merged commit 2633e89 into master Nov 20, 2024
1 check passed
@qroll qroll deleted the MOL-16700 branch November 20, 2024 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qroll qroll qroll approved these changes

Assignees

@AnuMutyala AnuMutyala

Labels
enhancement New feature or request
Projects
None yet
Milestone
v2.9.0-canary.1
Development

Successfully merging this pull request may close these issues.
2 participants
@AnuMutyala @qroll